MSVC determinism feature should use /Brepro with linking#713
Open
b-spencer wants to merge 1 commit into
Open
Conversation
The `/Brepro` (undocumented) argument to MSVC applies to both the compiler and the linker. The recent commit 94bda81 in bazelbuild#408 fixed determinism with MSVC by passing the argument to the compiler, but not the linker. Since the flag is undocumented, it is not clear whether it makes a difference when linking MSVC-compiled objects that were themselves compiled with `/Brepro`, but passing it to the linker, too, helps ensure that it is applies in all cases, such as cases were the linker is used on objects built from other languages. This change adds `all_link_actions` to the list of actions that get the argument. See llvm/llvm-project#37777 for some of the scant documentation that`lld-link` (and thus real `link.exe`) accepts this option.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/Brepro(undocumented) argument to MSVC applies to both the compiler and the linker.The recent commit 94bda81 in #408 fixed determinism with MSVC by passing the argument to the compiler, but not the linker.
Since the flag is undocumented, it is not clear whether it makes a difference when linking MSVC-compiled objects that were themselves compiled with
/Brepro, but passing it to the linker helps ensure that it is applies in all cases, such as when linker is used with objects built from other languages.This change adds
all_link_actionsto the list of actions that get the argument.See llvm/llvm-project#37777 for some of the scant documentation that
lld-link(and thus reallink.exe) accepts this option.